Skip to content

Add Windows Test Runners for All Core Test Suites #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Aug 20, 2025
Merged

Add Windows Test Runners for All Core Test Suites #1439

merged 28 commits into from
Aug 20, 2025

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Jul 31, 2025 •
edited
Loading

Overview

  • Add Windows test runners to Github Actions.
    • This requires manually installs of Python using the setup-python action, which is a bit of a regression from our nice CI image. Hopefully this isn't a big deal for just the core suites, if it is we may have to explore a Windows docker image for the CI.
  • Add Windows test environments for all core test suites in tox.
  • Initial Windows support limited to Python 3.13

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.87s
✅ MARKDOWN markdownlint 7 0 0 0 1.22s
✅ MARKDOWN markdown-link-check 7 0 0 21.68s
✅ PYTHON ruff 922 0 0 0 0.97s
✅ PYTHON ruff-format 922 0 0 0 0.33s
✅ YAML prettier 14 0 0 0 1.38s
✅ YAML v8r 14 0 0 5.73s
✅ YAML yamllint 14 0 0 0.65s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch from 1630b42 to 32eb0f7 Compare July 31, 2025 18:29
@mergify mergify bot added the tests-failing Tests failing in CI. label Jul 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.31%. Comparing base (02d0071) to head (d94deca).

Files with missing lines Patch % Lines
newrelic/core/agent_control_health.py 82.22% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           develop-windows    #1439      +/-   ##
===================================================
- Coverage            81.37%   81.31%   -0.07%     
===================================================
  Files                  208      208              
  Lines                23566    23586      +20     
  Branches              3717     3723       +6     
===================================================
  Hits                 19178    19178              
- Misses                3132     3167      +35     
+ Partials              1256     1241      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch from c9a0c97 to e1771d6 Compare July 31, 2025 20:13
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch 9 times, most recently from 83b2d1f to f660276 Compare August 13, 2025 22:06
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 14, 2025
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch 3 times, most recently from c33a036 to 29e450e Compare August 14, 2025 19:43
@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 14, 2025
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch from 29e450e to 3e3a2c3 Compare August 14, 2025 19:54
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 14, 2025
hmstepanek
hmstepanek reviewed Aug 15, 2025
View reviewed changes
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting this now so I can get this feedback to you-I'd like to take a closer look at the healthcheck section changes when I have some more time.

@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 15, 2025
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch 2 times, most recently from 346bdba to 357154a Compare August 16, 2025 00:30
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch from 5856722 to 3878eb1 Compare August 18, 2025 16:30
@TimPansino TimPansino force-pushed the feature-windows-ci-tests branch from 3878eb1 to 4762065 Compare August 18, 2025 16:32
@TimPansino
Copy link
Contributor Author

@hmstepanek I've reworked the tests.yml workflow and tox.ini to include Amd64 and Arm64 testing for both Linux and Windows systems. If you could re-review those files that would be great.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 18, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Aug 18, 2025
hmstepanek
hmstepanek approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing the rest-looks good!

@TimPansino TimPansino merged commit b240942 into develop-windows Aug 20, 2025
62 checks passed
@TimPansino TimPansino deleted the feature-windows-ci-tests branch August 20, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmstepanek hmstepanek hmstepanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimPansino @codecov-commenter @hmstepanek